Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres: remove internal timeouts #1149

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Nov 17, 2023

This removes all the internal timeouts for this package. The idea was to keep execution time bounded, but it's becoming increasingly clear this is just a source of problems.

@hdonnay hdonnay requested a review from a team as a code owner November 17, 2023 22:16
@hdonnay hdonnay requested review from crozzy and removed request for a team November 17, 2023 22:16
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9210797) 52.38% compared to head (d3cad1d) 52.22%.
Report is 1 commits behind head on main.

Files Patch % Lines
datastore/postgres/affectedmanifest.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
- Coverage   52.38%   52.22%   -0.17%     
==========================================
  Files         221      221              
  Lines       16959    16878      -81     
==========================================
- Hits         8884     8814      -70     
+ Misses       7265     7255      -10     
+ Partials      810      809       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hdonnay hdonnay added the needs-changelog Label for PRs that need a changelog note. label Nov 29, 2023
@hdonnay hdonnay force-pushed the bug/timeout-hunting branch 2 times, most recently from cbf8104 to f57cfb4 Compare December 12, 2023 19:05
Copy link
Contributor

@crozzy crozzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry, might have gone a little stale but I don't think there has been too much churn in the postgres package

This removes all the internal timeouts for this package. The idea was to
keep execution time bounded, but it's becoming increasingly clear this
is just a source of problems.

Signed-off-by: Hank Donnay <[email protected]>
@hdonnay
Copy link
Member Author

hdonnay commented Dec 19, 2023

/fast-forward

@github-actions github-actions bot merged commit d3cad1d into quay:main Dec 19, 2023
9 checks passed
@hdonnay hdonnay deleted the bug/timeout-hunting branch December 19, 2023 22:54
@hdonnay hdonnay removed the needs-changelog Label for PRs that need a changelog note. label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants