From 5c0f3840202912aa72ba5a35bba341be8ca51d33 Mon Sep 17 00:00:00 2001 From: "Matteo Franci a.k.a. Fugerit" Date: Sat, 13 Jul 2024 16:00:42 +0200 Subject: [PATCH 1/2] Doc for parameter quarkus.native.add-all-charsets https://github.com/quarkusio/quarkus/issues/41876 --- .../src/main/java/io/quarkus/deployment/pkg/NativeConfig.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java b/core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java index 5f25613e770c1..4313d0ced4e93 100644 --- a/core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java +++ b/core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java @@ -122,7 +122,7 @@ public interface NativeConfig { String fileEncoding(); /** - * If all character sets should be added to the native image. This increases image size + * If all character sets should be added to the native image (Different from GraalVM option : -H:+AddAllCharsets; this flag enables quarkus extensions to do some specific work). This increases image size */ @WithDefault("false") boolean addAllCharsets(); From 5b4eab8e330275b8997030ba544470493771e150 Mon Sep 17 00:00:00 2001 From: Guillaume Smet Date: Tue, 16 Jul 2024 14:56:53 +0200 Subject: [PATCH 2/2] Reword things a bit --- .../main/java/io/quarkus/deployment/pkg/NativeConfig.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java b/core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java index 4313d0ced4e93..c4e4c476fbb43 100644 --- a/core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java +++ b/core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java @@ -122,7 +122,12 @@ public interface NativeConfig { String fileEncoding(); /** - * If all character sets should be added to the native image (Different from GraalVM option : -H:+AddAllCharsets; this flag enables quarkus extensions to do some specific work). This increases image size + * If all character sets should be added to the native executable. + *

+ * Note that some extensions (e.g. the Oracle JDBC driver) also take this setting into account to enable support for all + * charsets at the extension level. + *

+ * This increases image size. */ @WithDefault("false") boolean addAllCharsets();