Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not show '1970' if bad data comes back for an extension date #340

Open
1 of 2 tasks
holly-cummins opened this issue Sep 15, 2023 · 1 comment · Fixed by #341
Open
1 of 2 tasks

Should not show '1970' if bad data comes back for an extension date #340

holly-cummins opened this issue Sep 15, 2023 · 1 comment · Fixed by #341

Comments

@holly-cummins
Copy link
Collaborator

holly-cummins commented Sep 15, 2023

See, for example (for the moment), https://quarkus.io/extensions/io.quarkiverse.ironjacamar/quarkus-ironjacamar

image

I assume we're getting a 0 for the date, but we should turn that into an undefined and display nothing.

Edit:

There are two parts to the fix:

@holly-cummins
Copy link
Collaborator Author

In this particular case, it looks like the timestamp is out by a factor of a thousand. That's harder to detect, and I'm not entirely sure what would cause it. We could try and detect the situation and multiply dates by a thousand if they seem too small, but I think before we invest in that we want to understand why this is happening.

@holly-cummins holly-cummins changed the title Should not show '1970' if an extension date can't be determined Should not show '1970' if bad data comes back for an extension date Sep 15, 2023
@holly-cummins holly-cummins reopened this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant