Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fault tolerance notebook doc and test update #6158

Closed
wants to merge 2 commits into from

Conversation

carthick
Copy link
Contributor

No description provided.

@CirqBot CirqBot added the size: M 50< lines changed <250 label Jun 22, 2023
@mpharrigan mpharrigan added the area/cirq-ft Issues related to the Cirq-FT sub-package label Jul 26, 2023
@tanujkhattar
Copy link
Collaborator

@carthick What's the status of this PR? Do you plan to continue to work on it?

I looked at the test failures and they are happening because we need to insert a pip install cirq-ft on top of each notebook so that they can run in an isolated environment. For reference, you can look at other notebooks that already exist, for example -

" import cirq\n",

Once you update the notebooks to include the pip install statement, I think it should work.

@carthick
Copy link
Contributor Author

carthick commented Aug 2, 2023

@tanujkhattar I am working on this and will update the Pull request

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (14baaa5) to head (834d482).
Report is 163 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6158      +/-   ##
==========================================
- Coverage   97.37%   97.34%   -0.04%     
==========================================
  Files        1116     1116              
  Lines       96042    95998      -44     
==========================================
- Hits        93524    93449      -75     
- Misses       2518     2549      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added Stale and removed Stale labels Feb 13, 2024
@github-actions github-actions bot added the Stale label Mar 18, 2024
@dstrain115
Copy link
Collaborator

This PR is stale. cirq-ft has moved to qualtran.

If you want to continue to work on this PR, please reopen it on this repository:
https://github.com/quantumlib/Qualtran

@dstrain115 dstrain115 closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cirq-ft Issues related to the Cirq-FT sub-package size: M 50< lines changed <250 Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants