Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cirq-FT: Isolated pytest fails at head for cirq-ft notebooks #6227

Closed
NoureldinYosri opened this issue Aug 1, 2023 · 3 comments · Fixed by #6229
Closed

Cirq-FT: Isolated pytest fails at head for cirq-ft notebooks #6227

NoureldinYosri opened this issue Aug 1, 2023 · 3 comments · Fixed by #6229
Assignees
@NoureldinYosri
Labels
area/cirq-ft Issues related to the Cirq-FT sub-package kind/bug-report Something doesn't seem to work. triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add

Comments

@NoureldinYosri
Copy link
Collaborator

The notebook tests fail with jupyter_client.kernelspec.NoSuchKernel: No such kernel named python3

Examples:
@NoureldinYosri NoureldinYosri added kind/bug-report Something doesn't seem to work. area/cirq-ft Issues related to the Cirq-FT sub-package labels Aug 1, 2023
@tanujkhattar
Copy link
Collaborator

tanujkhattar commented Aug 2, 2023 •
edited
Loading

Since the failure arises from the execute_notebook method, #6158 should help fix this issue.

But I'm not sure why this is failing right now

@mpharrigan
Copy link
Collaborator

I ran into this bumping dependencies in qualtran

quantumlib/Qualtran@cee761e

@verult
Copy link
Collaborator

verult commented Aug 2, 2023

From cirq cynque: need to add an explicit dependency to ipykernel

@senecameeks senecameeks added the triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add label Aug 2, 2023
@NoureldinYosri NoureldinYosri linked a pull request Aug 2, 2023 that will close this issue
Fix Isolated pytest #6229
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NoureldinYosri NoureldinYosri

Labels
area/cirq-ft Issues related to the Cirq-FT sub-package kind/bug-report Something doesn't seem to work. triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Isolated pytest quantumlib/Cirq
5 participants
@verult @mpharrigan @NoureldinYosri @tanujkhattar @senecameeks