Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix a few typos #2842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timgates42
Copy link
Contributor

There are small typos in:

  • tests/test_assets.py
  • zipline/data/minute_bars.py
  • zipline/errors.py
  • zipline/finance/controls.py

Fixes:

  • Should read constraint rather than contraint.
  • Should read slippage rather than slipage.
  • Should read identifier rather than identifer.
  • Should read considered rather than consdered.

Semi-automated pull request generated by
https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md

There are small typos in:
- tests/test_assets.py
- zipline/data/minute_bars.py
- zipline/errors.py
- zipline/finance/controls.py

Fixes:
- Should read `constraint` rather than `contraint`.
- Should read `slippage` rather than `slipage`.
- Should read `identifier` rather than `identifer`.
- Should read `considered` rather than `consdered`.

Signed-off-by: Tim Gates <[email protected]>
@andycwang
Copy link

andycwang commented Jul 20, 2022 via email

Copy link

@adamLutPhi adamLutPhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos are corrected

@andycwang
Copy link

andycwang commented Sep 16, 2022 via email

Copy link

@adamLutPhi adamLutPhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code has been Reviewed: typos has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants