Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake for QtService #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add cmake for QtService #16

wants to merge 2 commits into from

Conversation

KangLin
Copy link

@KangLin KangLin commented Jul 9, 2021

No description provided.

@xakod
Copy link

xakod commented Feb 14, 2022

What about others?

@xakod
Copy link

xakod commented Feb 15, 2022

@KangLin if you wanna merge it to upstream, go to https://codereview.qt-project.org with your pr

@KangLin
Copy link
Author

KangLin commented Feb 15, 2022

@Jihadist I want to merge it to the repository master. who can merge it?

@xakod
Copy link

xakod commented Feb 15, 2022

@KangLin pls look at https://www.qt.io/community/contribute-to-qt and then it's for you https://codereview.qt-project.org/q/project:qt-solutions/qt-solutions. Github repo is read-only, they merge only with codereview.qt-project.org

@KangLin
Copy link
Author

KangLin commented Feb 16, 2022

I has add ssh key in https://codereview.qt-project.org/admin/repos/qt-solutions/qt-solutions
and git clone "ssh://[email protected]:29418/qt-solutions/qt-solutions" && scp -p -P 29418 [email protected]:hooks/commit-msg "qt-solutions/.git/hooks/"

but I don't push it.
l@l-Lenovo:/home/qt-solutions$ git push
枚举对象中: 41, 完成.
对象计数中: 100% (41/41), 完成.
使用 2 个线程进行压缩
压缩对象中: 100% (30/30), 完成.
写入对象中: 100% (30/30), 7.36 KiB | 1.84 MiB/s, 完成.
总共 30 (差异 15),复用 0 (差异 0)
remote: Resolving deltas: 100% (15/15)
remote: error: branch refs/heads/master:
remote: To push into this reference you need 'Push' rights.
remote: User: kanglin
remote: Contact an administrator to fix the permissions
remote: Processing changes: refs: 1, done
To ssh://codereview.qt-project.org:29418/qt-solutions/qt-solutions
! [remote rejected] master -> master (prohibited by Gerrit: not permitted: update)
error: 推送一些引用到 'ssh://[email protected]:29418/qt-solutions/qt-solutions' 失败

How do I do this? @Jihadist

@xakod
Copy link

xakod commented Feb 16, 2022

@KangLin you don't have permissons to push directly to master. You can push to your own branch.
Look here https://wiki.qt.io/Qt_Contribution_Guidelines pls
You need git gpush

@KangLin
Copy link
Author

KangLin commented Feb 16, 2022

@Jihadist Yes! then where to watch my pacth? EWS url?
l@l-Lenovo:/home/qt-solutions$ /home/qtrepotools/bin/git-gpush --branch orign:cmake
Notice: HEAD has no upstream remote; defaulting to origin.
Attempted to push 2 loose Change(s):
Icb8ce9458 (QtService: add cmake)
I1a2aa1cb8 (QtService: support qt6)
Please specify exact ranges.

@xakod
Copy link

xakod commented Feb 16, 2022

@KangLin if you push it you will see it here https://codereview.qt-project.org/dashboard/self but looks like it wasnt pushed

@KangLin
Copy link
Author

KangLin commented Feb 16, 2022

@Jihadist I am not see it. Is this right?
图片

@xakod
Copy link

xakod commented Feb 16, 2022

@KangLin You are on the right track 👍
Push your changes there

@KangLin
Copy link
Author

KangLin commented Feb 16, 2022

@Jihadist thank you! It is OK! Do you can review it?

图片

@KangLin KangLin force-pushed the master branch 3 times, most recently from f60d731 to 9fd2c34 Compare February 17, 2022 13:05
Change-Id: Icb8ce9458340d2dcc2f65bafa07ca282420751e4
Change-Id: I1a2aa1cb83e7cbff96ba1d4f3bd2cc7d8c0756cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants