Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(backend): if there is a qri connect process already running, ensure it is up-to-date #670

Open
ramfox opened this issue Nov 10, 2020 · 0 comments
Assignees
Labels
backend bug Something isn't working

Comments

@ramfox
Copy link
Member

ramfox commented Nov 10, 2020

We've had a few users come to us with issues when they have been using an older version of Qri & are now downloading and launching the new Qri Desktop.

We recently refactored the start-up process in Desktop, that more robustly checks that the version of Qri core you have in your PATH is compatible with the version of Desktop you are running before we launch the backend daemon. However, we also allow Desktop to piggyback off of already running processes. This allows an advanced user to run Qri core on their own via the CLI, especially if they are trying to use a Qri repo that is not saved in the default location.

But, we are not checking to see if that already running Qri process is compatible with the version of Desktop the user is running! To remedy this, if there is a qri connect process running, and it's out of date, kill the process and launch our own.

We can tell if a process is out of date by fetching from the /version endpoint and comparing the result with the expected backend version.

@ramfox ramfox added bug Something isn't working backend labels Nov 10, 2020
@ramfox ramfox self-assigned this Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant