Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing tests from recent additions #19

Open
7 tasks
b5 opened this issue Aug 26, 2019 · 0 comments
Open
7 tasks

add missing tests from recent additions #19

b5 opened this issue Aug 26, 2019 · 0 comments
Labels

Comments

@b5
Copy link
Member

b5 commented Aug 26, 2019

Test are are missing from recent additions:

  • test getDagInfo hook on http via a 3rd requesting node
  • test remove unpinning
  • test remove hook
  • Lots of attention is needed no the p2p side:
    • full hooks test suite
  • setup codecov
    • run codecov tests with the race detector enabled

Finally, I've also seen some parallelism trip-ups that seems to stem from the timing around completion checks / final block not being added yet. This is mainly in the super-low-latency scenario of HTTP on the same computer. It'd be great to get a test that runs a 5-10 block dsync push any number of times checking for errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant