This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
feat(sn-filter-pane): apply collapseMode setting #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
old sorting when cardinal is same
column if it does not fit in first column
measuring height
and tweaking styling
width or height changes
veinfors
reviewed
Oct 2, 2023
packages/sn-filter-pane/src/components/ListboxGrid/distribute-always-expanded.ts
Outdated
Show resolved
Hide resolved
veinfors
reviewed
Oct 2, 2023
veinfors
reviewed
Oct 2, 2023
|
Just left a couple of comments on some mini stuff... But in general - Looks very good! |
veinfors
approved these changes
Oct 2, 2023
Co-authored-by: Christian Veinfors <[email protected]>
…always-expanded.ts Co-authored-by: Christian Veinfors <[email protected]>
DanielS-Qlik
approved these changes
Oct 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changing for the user?
collapseModecan be set to one of these options:auto,alwaysorneverto adjust how individual Litboxes should collapse/expand when the rendering space is changingAs long as we don't touch the
collapseModeoption (shown only under flag in sense-client) the behaviour should be exactly as before.