Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

feat: Add styling panel for filterpane (IM-4073) #325

Closed
wants to merge 9 commits into from
Closed

feat: Add styling panel for filterpane (IM-4073) #325

wants to merge 9 commits into from

Conversation

cosmar26
Copy link
Contributor

@cosmar26 cosmar26 commented Jul 6, 2023

Edit by @johanlahti) 2023-08-07:

  • I'm merging this (it's still under flag IM_4073_FILTERPANE_STYLING) so we can continue with the next tasks without risking merge conflicts
  • @CostInCode will continue with the remaining Nebula work (and maybe sn-filter-pane work too) when back

DONE:

  • General Tab
  • Chart Tab: Header and Content (font size and font color, to discuss if we need also font family too)

UNCERTAIN (@CostInCode will check when back):

  • Refactor (will check also if filterpane should re render for any styling panel change as it is right now - the latest commit is necessary for the listbox to receive the updated styling components array from the layout)
  • Testing: the styling panel can be tested only with another PR from Nebula. I will add a link when it is pushed

TODO (other PR:s):

  • Chart Tab: Selection State section
Screenshot 2023-07-06 at 10 32 19 Screenshot 2023-07-20 at 14 14 23

@johanlahti johanlahti changed the title Add styling panel for filterpane (#IM-4073) feat(sn-filter-pane): Add styling panel for filterpane (IM-4073) Aug 7, 2023
@johanlahti johanlahti changed the title feat(sn-filter-pane): Add styling panel for filterpane (IM-4073) feat: Add styling panel for filterpane (IM-4073) Aug 8, 2023
@johanlahti
Copy link
Collaborator

Replaced by: #338

@johanlahti johanlahti closed this Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants