Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label strategies #52

Open
yianni-ververis opened this issue Mar 13, 2018 · 2 comments
Open

Label strategies #52

yianni-ververis opened this issue Mar 13, 2018 · 2 comments
Labels
Type: Improvement Minor improvement of an existing feature

Comments

@yianni-ververis
Copy link

Description

There is only one strategy for labels, "bar" and it only applies to bar charts. This means that any other chart, like a pie, you cannot have labels

Steps to Reproduce

  1. Add Labels component into a pie component
  2. Set strategy type "bar"
Expected behavior

See labels on "path" element

Actual behavior

If I have time, I will try and add it under src/core/chart-components/labels/strategies.js

Versions

  • picasso.js:
  • Browser:
  • [Other relevant versions]
@yianni-ververis
Copy link
Author

It needs one for circle too, for scatter plots etc

@cbt1 cbt1 added the Type: Improvement Minor improvement of an existing feature label Mar 15, 2018
@cbt1
Copy link
Collaborator

cbt1 commented Mar 15, 2018

Agree, we need to add strategies for other types than "bars". An FYI though, the bar strategy should "work" with any shape as the position is based on the bounding rectangle of a shape.

@miralemd miralemd changed the title labels Strategies Label strategies May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Minor improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants