Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing themes #2

Open
ebraminio opened this issue Dec 8, 2017 · 4 comments
Open

Providing themes #2

ebraminio opened this issue Dec 8, 2017 · 4 comments

Comments

@ebraminio
Copy link

ebraminio commented Dec 8, 2017

This works just fantastic. Thanks!

One suggestion, different apps provide https://github.com/gstraube/cythara/tree/master/app/src/main/java/com/github/cythara/tuning themes. Maybe this can also support a very lightweight instruments' notes frequency definition? This would help on less known/local instruments not aligning perfectly with chromatic notes and western instruments. For example Setar, a Persian local instrument, has a frequency configuration like this per this:

C3: 244
G2: 183
C3: 244
C2: 122

(not sure about the terminology used here)

@qiuxiang
Copy link
Owner

qiuxiang commented Dec 8, 2017

Sounds good, but I want to keep this project simple. Your suggestion can be implemented in a new project. Because it includes some user interaction, it's good to use js frameworks like react.

@ebraminio
Copy link
Author

ebraminio commented Dec 8, 2017

Thanks. All I like to be added is one or two levels of select/option with default to current behavior to be honest and maybe some buttons for playing a specific note (and I know that crosses the border :P). Lets see if I can do it, your work is just fantastic from simplicity aspect and that is just great, thanks! :)

@qiuxiang
Copy link
Owner

qiuxiang commented Dec 9, 2017

This app already provided toggleAutoMode method (missing switch):

screen shot 2017-12-09 at 3 19 37 pm

Click the note name to play the specific note. It uses oscillator.

@ebraminio
Copy link
Author

Wow, it provides many fantastic hidden goodies! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants