Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve volumes and logging #202

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Improve volumes and logging #202

merged 5 commits into from
Sep 24, 2024

Conversation

tellet-q
Copy link
Contributor

  • Add logging to search_one function
  • Use default docker volumes

@tellet-q tellet-q changed the title Some CI improvements Improve volumes and logging Sep 20, 2024
KShivendu
KShivendu approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@KShivendu KShivendu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I hope you've tested it locally :)

@tellet-q
Copy link
Contributor Author

Well, it looks a bit verbose in the logs but in this case I think it's OK.

@tellet-q tellet-q merged commit 6bab477 into master Sep 24, 2024
1 of 3 checks passed
@tellet-q tellet-q deleted the fix/improve-ci branch September 24, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KShivendu KShivendu KShivendu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tellet-q @KShivendu