Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* feat(embedding.py): add support for v1.5 models #25

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

NirantK
Copy link
Contributor

@NirantK NirantK commented Oct 16, 2023

  • feat(embedding.py): change default model to v1.5

…/bge-base-en-v1.5 models

* feat(embedding.py): change default model to v1.5
@NirantK NirantK requested a review from generall October 16, 2023 11:45
@NirantK NirantK merged commit 66c5cf7 into main Oct 16, 2023
12 checks passed
@NirantK NirantK deleted the support-v1.5-models branch October 16, 2023 11:59
@Anush008
Copy link
Member

Hey @NirantK, recent changes have reverted the default model back to "BAAI/bge-small-en" instead of "BAAI/bge-small-en-v1.5".

class FlagEmbedding(Embedding):
"""
Implementation of the Flag Embedding model.
Args:
Embedding (_type_): _description_
"""
def __init__(
self,
model_name: str = "BAAI/bge-small-en",
max_length: int = 512,
cache_dir: str = None,
threads: int = None,
):

@NirantK
Copy link
Contributor Author

NirantK commented Oct 18, 2023

On it.

@NirantK
Copy link
Contributor Author

NirantK commented Oct 18, 2023

Not urgent. Since the DefaultEmbedding Class sets this parameter, and what we recommend importing as well. Will be made consistent via #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants