Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerizing qauld to enable self-hosting #520

Open
brenodt opened this issue Jan 24, 2023 Discussed in #518 · 4 comments
Open

Dockerizing qauld to enable self-hosting #520

brenodt opened this issue Jan 24, 2023 Discussed in #518 · 4 comments
Assignees
Labels
Feature Request A new feature, that extends functionality

Comments

@brenodt
Copy link
Collaborator

brenodt commented Jan 24, 2023

Opening an issue so it's easier to track the status of this feature.

Discussed in #518

Originally posted by huang12zheng January 24, 2023
I found that without documentation and best practices for relay nodes,
Maybe we could add it somewhere?

This is an example that I wrote
https://github.com/huang12zheng/qaul.net/tree/dockerfile

@brenodt brenodt added the Feature Request A new feature, that extends functionality label Jan 24, 2023
@brenodt brenodt self-assigned this Jan 24, 2023
@MathJud
Copy link
Member

MathJud commented Feb 5, 2023

The feature has been documented here:
https://qaul.github.io/qaul.net/#/qaul/infra/self-hosting-qauld

And committed via this pull request: #526

Thanks @brenodt for doing so

@MathJud
Copy link
Member

MathJud commented Feb 5, 2023

A nice thing to have for the future, could be the possibility to define the "Port" and the node "Name" in a docker-compose.env file and make it accessible to the docker container via the environment settings in dock-compose.yml.

Just in case, that it would be preferable to overwrite the startup command in the dockerfile itself we could do so in the docker-compose.yml command section. IMHO the environment option gives us most probably enough flexibility.

@brenodt
Copy link
Collaborator Author

brenodt commented Feb 6, 2023

I do agree, this sounds reasonable.
One issue could be the fact that the name and port flags only take effect the first time the image is spinned-up - subsequent ones take the config.yaml file.
The user can, of course, change it manually: we already describe in the docs how to map the configuration folder into the host.
But this renders the environment variable only useful on the first execution of the container, I believe.

@taro-ball
Copy link

One solution is for qauld to check for the presence of env variable and override the value from config.yaml if the variable is present. Maybe write something to the log like "env variable found, overriding config port value to wxyz". Could we request a feature like that? This is the best practice for containerized apps see https://medium.com/hackernoon/how-to-dockerize-any-application-b60ad00e76da (#7).

Or I could easily add an envsubst bit for the entry point, no app modification required in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request A new feature, that extends functionality
Projects
None yet
Development

No branches or pull requests

3 participants