fix: Handle null term char #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For tcpip connection, handle when termination char is \0 rather than \n or \r.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
=======================================
Coverage ? 23.02%
=======================================
Files ? 23
Lines ? 3318
Branches ? 457
=======================================
Hits ? 764
Misses ? 2537
Partials ? 17
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Can you add an entry to the changelog and I will merge ? |
|
Anything else needed on this PR? |
|
Sorry it went out of my radar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tcpip connection, handle when termination char is \0 rather than \n or \r.
Closes #393