-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the GCPDefinition #476
base: main
Are you sure you want to change the base?
Conversation
@BENR0 ^ |
Codecov Report
@@ Coverage Diff @@
## main #476 +/- ##
==========================================
+ Coverage 94.28% 94.29% +0.01%
==========================================
Files 69 70 +1
Lines 12394 12417 +23
==========================================
+ Hits 11686 11709 +23
Misses 708 708
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand all of the use cases for GCPs, but I thought they were a sparse version representing something much larger. How does this work here with your definition? Put another way, I thought the user would give GCPs and like an overall shape of the area and that would be used to generate the full lons/lats on the fly. Where is get_coarse_bbox_lonlats
going to be used? It isn't used currently, right? How useful is it when we have access to the full lons/lats already? How will the user control whether "coarse" bounding boxes are good enough for their use case?
Yes, very good questions indeed.
|
I think another use case that was mentioned by @mraspaud was to be able to write geotiffs with only tiepoints. |
Add a new class called GCPDefinition (inherits from SwathDefinition) which provides access to the underlying gcps.
Use cases:
faster loading of coarse lon/lats (for the boundary)
if you want to write data with tiepoints
interpolate a fraction of what is needed.
Closes #xxxx
Tests added
Tests passed
Passes
git diff origin/main **/*py | flake8 --diff
Fully documented