Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce scan_size for overlapping scans #248

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mraspaud
Copy link
Member

This PR adds support for modis and viirs swath resampling with gradient search

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff
  • Fully documented

@mraspaud mraspaud self-assigned this Jan 20, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 91.135% when pulling c679eb4 on mraspaud:feature-npp-gradient into f710309 on pytroll:master.

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #248 into master will decrease coverage by 0.11%.
The diff coverage is 21.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   91.27%   91.15%   -0.12%     
==========================================
  Files          42       42              
  Lines        8243     8257      +14     
==========================================
+ Hits         7524     7527       +3     
- Misses        719      730      +11
Impacted Files Coverage Δ
pyresample/gradient/__init__.py 86.17% <21.42%> (-8.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f710309...c679eb4. Read the comment docs.

@djhoese
Copy link
Member

djhoese commented Jan 20, 2020

I believe the viirs and modis readers in Satpy have a "rows_per_scan" piece of metadata that I use for EWA resampling when available. I'm willing to switch it, but I think I'd argue that rows_per_scan is more explicit.

@djhoese
Copy link
Member

djhoese commented Mar 22, 2022

@mraspaud Any updates or thoughts on this PR after all your work on the other PRs? As I mentioned above there is rows_per_scan in the metadata for Satpy's VIIRS and MODIS readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants