Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix torch_logs to run on CPU devices #3082

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix torch_logs to run on CPU devices #3082

wants to merge 2 commits into from

Conversation

zzadxz
Copy link

@zzadxz zzadxz commented Oct 8, 2024 •
edited by pytorch-bot bot
Loading

Fixes #137285

Description

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #137285")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @williamwen42 @msaroufim @anijain2305

@zzadxz
Fix torch_logs to run on CPU devices
6f4b550 
Fixes #137285

Summary:
- Removed the CUDA device capability check that prevented the tutorial from running on non-CUDA devices.
- Updated tensor initialization to use CPU tensors by default by removing explicit `device="cuda"` arguments.
- Unindented the code block previously inside the `else` clause to align with the top-level scope.
- Ensured that all logging functionality works as expected on CPU devices.
@zzadxz
Merge pull request #1 from zzadxz/zzadxz-patch-1
6cc87a6 
Fix torch_logs to run on CPU devices
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3082

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 6cc87a6 with merge base 67ec2a5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @zzadxz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@zzadxz zzadxz mentioned this pull request Oct 8, 2024
Open
@svekars svekars requested a review from mlazos October 23, 2024 15:35
@svekars svekars added the torch.compile Torch compile and other relevant tutorials label Oct 23, 2024
@williamwen42
Copy link
Member

I think we want to keep this on CUDA in order to see inductor generated triton code? @svekars can we force this tutorial to run on a runner with GPU?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlazos mlazos Awaiting requested review from mlazos

Assignees
No one assigned
Labels
cla signed torch.compile Torch compile and other relevant tutorials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zzadxz @facebook-github-bot @williamwen42 @svekars