upgrade metadata call to use IMDSv2, only supported version soon #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
wdvr
added a commit
to pytorch/test-infra
that referenced
this pull request
Nov 1, 2024
this is a follow up on PR #5783 that enabled IMDSv2. We're about to remove support for IMDSv1 on our AWS account globally This is part of an effort to move all our calls across all pytorch repos to v2. See also: pytorch/FBGEMM#3297 pytorch/pytorch#138286 pytorch/torchsnapshot#180 pytorch/torchrec#2532 pytorch/torcheval#210
PaulZhang12
approved these changes
Nov 4, 2024
|
@PaulZhang12 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Soon we will only support metadata fetching for EC2 instances via IMDSv2 - this upgrades the existing v1 call to a v2 call - no functional changes
Test plan:
testing if the release_build.yaml workflow correctly fetches the instance metadata
NOTE: this workflow only runs on pypi release