Capture max memory reserved and malloc_retries metric #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64896100 |
che-sh
added a commit
to che-sh/torchrec
that referenced
this pull request
Oct 25, 2024
Summary: # This diff Adds two metrics to the pipeline benchmarks: * `num_alloc_retries` - this is bumped by one every time allocator cannot grab memory from device, and have to perform memory defrag/reclaiming * `max reserved memory` - metric that captures the total reserved memory in addition to already collected `max allocated memory` Differential Revision: D64896100
che-sh
force-pushed
the
export-D64896100
branch
from
ef436c0
to
9bcad19
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64896100 |
che-sh
force-pushed
the
export-D64896100
branch
from
9bcad19
to
f304cfc
Compare
che-sh
added a commit
to che-sh/torchrec
that referenced
this pull request
Oct 28, 2024
Summary: # This diff Adds two metrics to the pipeline benchmarks: * `num_alloc_retries` - this is bumped by one every time allocator cannot grab memory from device, and have to perform memory defrag/reclaiming * `max reserved memory` - metric that captures the total reserved memory in addition to already collected `max allocated memory` Differential Revision: D64896100
|
This pull request was exported from Phabricator. Differential Revision: D64896100 |
che-sh
force-pushed
the
export-D64896100
branch
from
f304cfc
to
3d2c9ea
Compare
che-sh
added a commit
to che-sh/torchrec
that referenced
this pull request
Oct 30, 2024
Summary: # This diff Adds two metrics to the pipeline benchmarks: * `num_alloc_retries` - this is bumped by one every time allocator cannot grab memory from device, and have to perform memory defrag/reclaiming * `max reserved memory` - metric that captures the total reserved memory in addition to already collected `max allocated memory` Reviewed By: dstaay-fb Differential Revision: D64896100
|
This pull request was exported from Phabricator. Differential Revision: D64896100 |
Summary: Pull Request resolved: pytorch#2520 # This diff Adds two metrics to the pipeline benchmarks: * `num_alloc_retries` - this is bumped by one every time allocator cannot grab memory from device, and have to perform memory defrag/reclaiming * `max reserved memory` - metric that captures the total reserved memory in addition to already collected `max allocated memory` Reviewed By: dstaay-fb Differential Revision: D64896100
che-sh
force-pushed
the
export-D64896100
branch
from
3d2c9ea
to
dceba28
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64896100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff
Adds two metrics to the pipeline benchmarks:
num_alloc_retries- this is bumped by one every time allocator cannot grab memory from device, and have to perform memory defrag/reclaimingmax reserved memory- metric that captures the total reserved memory in addition to already collectedmax allocated memoryDifferential Revision: D64896100