Change init method from fork-server to spawn #2427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63311340 |
|
This pull request was exported from Phabricator. Differential Revision: D63311340 |
xw285cornell
force-pushed
the
export-D63311340
branch
from
cd350ea
to
d24e191
Compare
xw285cornell
added a commit
to xw285cornell/torchrec
that referenced
this pull request
Sep 25, 2024
Summary: Pull Request resolved: pytorch#2427 It seems AMD GPU runtime doesn't quite work with forkserver for some reasons that we still need to debug. Basically hipMalloc will fail for subprocess. So just change it to spawn - I think it should be fine? Differential Revision: D63311340
|
This pull request was exported from Phabricator. Differential Revision: D63311340 |
xw285cornell
force-pushed
the
export-D63311340
branch
from
d24e191
to
2ef0e20
Compare
xw285cornell
added a commit
to xw285cornell/torchrec
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: pytorch#2427 It seems AMD GPU runtime doesn't quite work with forkserver for some reasons that we still need to debug. Basically hipMalloc will fail for subprocess. So just change it to spawn - I think it should be fine? Reviewed By: joebos Differential Revision: D63311340
Summary: Pull Request resolved: pytorch#2427 It seems AMD GPU runtime doesn't quite work with forkserver for some reasons that we still need to debug. Basically hipMalloc will fail for subprocess. So just change it to spawn - I think it should be fine? Reviewed By: joebos Differential Revision: D63311340
|
This pull request was exported from Phabricator. Differential Revision: D63311340 |
xw285cornell
force-pushed
the
export-D63311340
branch
from
2ef0e20
to
1dee4ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: It seems AMD GPU runtime doesn't quite work with forkserver for some reasons that we still need to debug. Basically hipMalloc will fail for subprocess. So just change it to spawn - I think it should be fine?
Differential Revision: D63311340