Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Document losses in README.md #2408

Merged
merged 14 commits into from
Sep 17, 2024
Merged

[Doc] Document losses in README.md #2408

merged 14 commits into from
Sep 17, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Sep 2, 2024 •
edited
Loading

@vmoens
Update
100bc9e 
[ghstack-poisoned]
@vmoens vmoens mentioned this pull request Sep 2, 2024
Merged
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 2, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2408

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 24 Unrelated Failures

As of commit 8820706 with merge base 605b4aa (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2024
vmoens added a commit that referenced this pull request Sep 2, 2024
@vmoens
[Doc] Document losses in README.md
4ae028b 
ghstack-source-id: 48ed5e42fd68e27093e1d05c95416e63174ce55e
Pull Request resolved: #2408
@vmoens
Update
c527bbe 
[ghstack-poisoned]
@vmoens vmoens mentioned this pull request Sep 2, 2024
Open
@vmoens vmoens added the documentation Improvements or additions to documentation label Sep 2, 2024
@vmoens
Update
704ccfc 
[ghstack-poisoned]
@vmoens
Update
f108720 
[ghstack-poisoned]
@vmoens
Update
5b8b716 
[ghstack-poisoned]
@vmoens vmoens mentioned this pull request Sep 9, 2024
Open
@vmoens
Update
ead64a2 
[ghstack-poisoned]
@vmoens
Update
dfd01f5 
[ghstack-poisoned]
@vmoens
Update
7b79cbb 
[ghstack-poisoned]
@vmoens
Update
00b1f8f 
[ghstack-poisoned]
@vmoens
Update
8451bd8 
[ghstack-poisoned]
@vmoens
Update
b473a8a 
[ghstack-poisoned]
@vmoens
Update
15dca7a 
[ghstack-poisoned]
@vmoens
Update
b547a7f 
[ghstack-poisoned]
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 146. Improved: $\large\color{#35bf28}13$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 60.7685ms 60.2197ms 16.6059 Ops/s 16.5419 Ops/s $\color{#35bf28}+0.39\%$
test_sync 41.8964ms 32.5533ms 30.7188 Ops/s 30.3774 Ops/s $\color{#35bf28}+1.12\%$
test_async 53.6189ms 31.2258ms 32.0248 Ops/s 32.0058 Ops/s $\color{#35bf28}+0.06\%$
test_simple 0.5047s 0.4314s 2.3179 Ops/s 2.4256 Ops/s $\color{#d91a1a}-4.44\%$
test_transformed 0.5888s 0.5761s 1.7359 Ops/s 1.7182 Ops/s $\color{#35bf28}+1.03\%$
test_serial 1.2969s 1.2916s 0.7742 Ops/s 0.7547 Ops/s $\color{#35bf28}+2.58\%$
test_parallel 1.2040s 1.1250s 0.8889 Ops/s 0.8876 Ops/s $\color{#35bf28}+0.14\%$
test_step_mdp_speed[True-True-True-True-True] 0.2464ms 27.1151μs 36.8798 KOps/s 35.2812 KOps/s $\color{#35bf28}+4.53\%$
test_step_mdp_speed[True-True-True-True-False] 48.0490μs 16.2433μs 61.5638 KOps/s 61.2965 KOps/s $\color{#35bf28}+0.44\%$
test_step_mdp_speed[True-True-True-False-True] 42.1190μs 15.8281μs 63.1787 KOps/s 61.8424 KOps/s $\color{#35bf28}+2.16\%$
test_step_mdp_speed[True-True-True-False-False] 64.5400μs 9.4129μs 106.2372 KOps/s 105.3629 KOps/s $\color{#35bf28}+0.83\%$
test_step_mdp_speed[True-True-False-True-True] 71.4740μs 29.3155μs 34.1116 KOps/s 32.9192 KOps/s $\color{#35bf28}+3.62\%$
test_step_mdp_speed[True-True-False-True-False] 45.8560μs 17.9752μs 55.6323 KOps/s 54.6733 KOps/s $\color{#35bf28}+1.75\%$
test_step_mdp_speed[True-True-False-False-True] 45.7550μs 17.5619μs 56.9415 KOps/s 56.3096 KOps/s $\color{#35bf28}+1.12\%$
test_step_mdp_speed[True-True-False-False-False] 48.3300μs 11.0519μs 90.4824 KOps/s 88.6791 KOps/s $\color{#35bf28}+2.03\%$
test_step_mdp_speed[True-False-True-True-True] 67.3060μs 30.8030μs 32.4644 KOps/s 31.0940 KOps/s $\color{#35bf28}+4.41\%$
test_step_mdp_speed[True-False-True-True-False] 47.9090μs 19.6127μs 50.9874 KOps/s 50.1372 KOps/s $\color{#35bf28}+1.70\%$
test_step_mdp_speed[True-False-True-False-True] 63.3120μs 17.5256μs 57.0595 KOps/s 55.4595 KOps/s $\color{#35bf28}+2.88\%$
test_step_mdp_speed[True-False-True-False-False] 34.1940μs 11.0501μs 90.4965 KOps/s 89.0739 KOps/s $\color{#35bf28}+1.60\%$
test_step_mdp_speed[True-False-False-True-True] 81.1220μs 32.4698μs 30.7978 KOps/s 29.9020 KOps/s $\color{#35bf28}+3.00\%$
test_step_mdp_speed[True-False-False-True-False] 54.6220μs 21.0017μs 47.6152 KOps/s 46.5175 KOps/s $\color{#35bf28}+2.36\%$
test_step_mdp_speed[True-False-False-False-True] 40.9360μs 18.9153μs 52.8671 KOps/s 51.1659 KOps/s $\color{#35bf28}+3.32\%$
test_step_mdp_speed[True-False-False-False-False] 51.1160μs 12.5602μs 79.6164 KOps/s 77.9626 KOps/s $\color{#35bf28}+2.12\%$
test_step_mdp_speed[False-True-True-True-True] 58.5790μs 30.8051μs 32.4621 KOps/s 31.3330 KOps/s $\color{#35bf28}+3.60\%$
test_step_mdp_speed[False-True-True-True-False] 62.1760μs 19.2313μs 51.9984 KOps/s 50.2161 KOps/s $\color{#35bf28}+3.55\%$
test_step_mdp_speed[False-True-True-False-True] 75.5540μs 19.8223μs 50.4481 KOps/s 47.7873 KOps/s $\textbf{\color{#35bf28}+5.57\%}$
test_step_mdp_speed[False-True-True-False-False] 30.2970μs 12.2493μs 81.6371 KOps/s 80.4911 KOps/s $\color{#35bf28}+1.42\%$
test_step_mdp_speed[False-True-False-True-True] 80.7870μs 32.2824μs 30.9767 KOps/s 30.2299 KOps/s $\color{#35bf28}+2.47\%$
test_step_mdp_speed[False-True-False-True-False] 47.5390μs 20.8336μs 47.9993 KOps/s 46.6270 KOps/s $\color{#35bf28}+2.94\%$
test_step_mdp_speed[False-True-False-False-True] 2.9402ms 21.5974μs 46.3019 KOps/s 45.1232 KOps/s $\color{#35bf28}+2.61\%$
test_step_mdp_speed[False-True-False-False-False] 53.7210μs 13.8133μs 72.3938 KOps/s 72.1544 KOps/s $\color{#35bf28}+0.33\%$
test_step_mdp_speed[False-False-True-True-True] 64.5800μs 33.8847μs 29.5119 KOps/s 28.6558 KOps/s $\color{#35bf28}+2.99\%$
test_step_mdp_speed[False-False-True-True-False] 77.2370μs 22.2402μs 44.9636 KOps/s 43.5277 KOps/s $\color{#35bf28}+3.30\%$
test_step_mdp_speed[False-False-True-False-True] 56.3750μs 21.2930μs 46.9639 KOps/s 45.3052 KOps/s $\color{#35bf28}+3.66\%$
test_step_mdp_speed[False-False-True-False-False] 37.8600μs 13.8095μs 72.4139 KOps/s 71.4270 KOps/s $\color{#35bf28}+1.38\%$
test_step_mdp_speed[False-False-False-True-True] 68.4980μs 35.2932μs 28.3341 KOps/s 27.3387 KOps/s $\color{#35bf28}+3.64\%$
test_step_mdp_speed[False-False-False-True-False] 68.3570μs 24.1420μs 41.4216 KOps/s 40.8014 KOps/s $\color{#35bf28}+1.52\%$
test_step_mdp_speed[False-False-False-False-True] 56.5850μs 22.8452μs 43.7728 KOps/s 42.9636 KOps/s $\color{#35bf28}+1.88\%$
test_step_mdp_speed[False-False-False-False-False] 50.9850μs 15.0690μs 66.3615 KOps/s 64.9438 KOps/s $\color{#35bf28}+2.18\%$
test_values[generalized_advantage_estimate-True-True] 13.1383ms 9.5584ms 104.6199 Ops/s 105.6963 Ops/s $\color{#d91a1a}-1.02\%$
test_values[vec_generalized_advantage_estimate-True-True] 37.3766ms 33.2291ms 30.0941 Ops/s 28.3213 Ops/s $\textbf{\color{#35bf28}+6.26\%}$
test_values[td0_return_estimate-False-False] 0.2216ms 0.1663ms 6.0145 KOps/s 6.0728 KOps/s $\color{#d91a1a}-0.96\%$
test_values[td1_return_estimate-False-False] 23.9476ms 23.5351ms 42.4897 Ops/s 42.2528 Ops/s $\color{#35bf28}+0.56\%$
test_values[vec_td1_return_estimate-False-False] 35.3961ms 33.3376ms 29.9961 Ops/s 28.0478 Ops/s $\textbf{\color{#35bf28}+6.95\%}$
test_values[td_lambda_return_estimate-True-False] 35.5082ms 34.1045ms 29.3216 Ops/s 29.3013 Ops/s $\color{#35bf28}+0.07\%$
test_values[vec_td_lambda_return_estimate-True-False] 35.5312ms 33.2905ms 30.0386 Ops/s 28.0231 Ops/s $\textbf{\color{#35bf28}+7.19\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.7814ms 8.1982ms 121.9775 Ops/s 119.9045 Ops/s $\color{#35bf28}+1.73\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 3.6497ms 2.0282ms 493.0378 Ops/s 512.2815 Ops/s $\color{#d91a1a}-3.76\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4791ms 0.3597ms 2.7801 KOps/s 2.7923 KOps/s $\color{#d91a1a}-0.44\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 48.2469ms 47.7826ms 20.9281 Ops/s 20.3554 Ops/s $\color{#35bf28}+2.81\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.5730ms 3.0417ms 328.7663 Ops/s 319.7771 Ops/s $\color{#35bf28}+2.81\%$
test_dqn_speed[False-None] 7.0861ms 1.3340ms 749.6113 Ops/s 764.7028 Ops/s $\color{#d91a1a}-1.97\%$
test_dqn_speed[False-backward] 1.9028ms 1.7998ms 555.6134 Ops/s 562.5447 Ops/s $\color{#d91a1a}-1.23\%$
test_dqn_speed[True-None] 0.7721ms 0.4658ms 2.1470 KOps/s 2.1575 KOps/s $\color{#d91a1a}-0.48\%$
test_dqn_speed[True-backward] 0.9082ms 0.8716ms 1.1473 KOps/s 1.1025 KOps/s $\color{#35bf28}+4.06\%$
test_dqn_speed[reduce-overhead-None] 0.6129ms 0.4693ms 2.1309 KOps/s 2.1039 KOps/s $\color{#35bf28}+1.28\%$
test_dqn_speed[reduce-overhead-backward] 0.9216ms 0.8756ms 1.1420 KOps/s 1.1275 KOps/s $\color{#35bf28}+1.29\%$
test_ddpg_speed[False-None] 3.5640ms 2.7691ms 361.1241 Ops/s 356.9269 Ops/s $\color{#35bf28}+1.18\%$
test_ddpg_speed[False-backward] 4.9208ms 3.9761ms 251.5033 Ops/s 254.1058 Ops/s $\color{#d91a1a}-1.02\%$
test_ddpg_speed[True-None] 1.4475ms 1.0114ms 988.7310 Ops/s 974.4686 Ops/s $\color{#35bf28}+1.46\%$
test_ddpg_speed[True-backward] 2.1920ms 1.9252ms 519.4246 Ops/s 514.9288 Ops/s $\color{#35bf28}+0.87\%$
test_ddpg_speed[reduce-overhead-None] 1.3052ms 1.0093ms 990.8256 Ops/s 961.9053 Ops/s $\color{#35bf28}+3.01\%$
test_ddpg_speed[reduce-overhead-backward] 1.9375ms 1.8903ms 529.0091 Ops/s 520.2809 Ops/s $\color{#35bf28}+1.68\%$
test_sac_speed[False-None] 9.1009ms 7.8069ms 128.0918 Ops/s 125.6844 Ops/s $\color{#35bf28}+1.92\%$
test_sac_speed[False-backward] 12.5260ms 10.5649ms 94.6533 Ops/s 94.1905 Ops/s $\color{#35bf28}+0.49\%$
test_sac_speed[True-None] 2.4352ms 1.8544ms 539.2633 Ops/s 533.6059 Ops/s $\color{#35bf28}+1.06\%$
test_sac_speed[True-backward] 3.7310ms 3.5384ms 282.6118 Ops/s 276.6656 Ops/s $\color{#35bf28}+2.15\%$
test_sac_speed[reduce-overhead-None] 2.3750ms 1.8575ms 538.3568 Ops/s 529.2071 Ops/s $\color{#35bf28}+1.73\%$
test_sac_speed[reduce-overhead-backward] 3.5777ms 3.5240ms 283.7718 Ops/s 278.9322 Ops/s $\color{#35bf28}+1.74\%$
test_redq_speed[False-None] 14.6971ms 12.9329ms 77.3220 Ops/s 76.4204 Ops/s $\color{#35bf28}+1.18\%$
test_redq_speed[False-backward] 23.7550ms 22.2464ms 44.9510 Ops/s 44.4296 Ops/s $\color{#35bf28}+1.17\%$
test_redq_speed[True-None] 5.0973ms 4.4934ms 222.5506 Ops/s 208.9843 Ops/s $\textbf{\color{#35bf28}+6.49\%}$
test_redq_speed[True-backward] 15.5249ms 12.4362ms 80.4106 Ops/s 82.1897 Ops/s $\color{#d91a1a}-2.16\%$
test_redq_speed[reduce-overhead-None] 5.3026ms 4.6636ms 214.4252 Ops/s 212.0898 Ops/s $\color{#35bf28}+1.10\%$
test_redq_speed[reduce-overhead-backward] 13.0315ms 12.1909ms 82.0284 Ops/s 78.0088 Ops/s $\textbf{\color{#35bf28}+5.15\%}$
test_redq_deprec_speed[False-None] 13.8354ms 12.6933ms 78.7815 Ops/s 75.1276 Ops/s $\color{#35bf28}+4.86\%$
test_redq_deprec_speed[False-backward] 22.0619ms 19.0612ms 52.4626 Ops/s 51.3302 Ops/s $\color{#35bf28}+2.21\%$
test_redq_deprec_speed[True-None] 4.2784ms 3.5623ms 280.7202 Ops/s 267.5321 Ops/s $\color{#35bf28}+4.93\%$
test_redq_deprec_speed[True-backward] 8.7780ms 8.0657ms 123.9820 Ops/s 119.1693 Ops/s $\color{#35bf28}+4.04\%$
test_redq_deprec_speed[reduce-overhead-None] 4.6870ms 3.7203ms 268.7923 Ops/s 265.5314 Ops/s $\color{#35bf28}+1.23\%$
test_redq_deprec_speed[reduce-overhead-backward] 9.1923ms 7.9825ms 125.2747 Ops/s 116.9245 Ops/s $\textbf{\color{#35bf28}+7.14\%}$
test_td3_speed[False-None] 8.5156ms 7.7619ms 128.8337 Ops/s 124.6563 Ops/s $\color{#35bf28}+3.35\%$
test_td3_speed[False-backward] 12.5160ms 10.1992ms 98.0465 Ops/s 94.0505 Ops/s $\color{#35bf28}+4.25\%$
test_td3_speed[True-None] 2.4631ms 1.9573ms 510.9000 Ops/s 497.8687 Ops/s $\color{#35bf28}+2.62\%$
test_td3_speed[True-backward] 4.4568ms 3.5302ms 283.2705 Ops/s 222.5363 Ops/s $\textbf{\color{#35bf28}+27.29\%}$
test_td3_speed[reduce-overhead-None] 2.1739ms 1.9160ms 521.9089 Ops/s 499.2104 Ops/s $\color{#35bf28}+4.55\%$
test_td3_speed[reduce-overhead-backward] 4.3656ms 3.5155ms 284.4507 Ops/s 268.2267 Ops/s $\textbf{\color{#35bf28}+6.05\%}$
test_cql_speed[False-None] 39.0314ms 35.1604ms 28.4411 Ops/s 26.0750 Ops/s $\textbf{\color{#35bf28}+9.07\%}$
test_cql_speed[False-backward] 45.8959ms 44.6622ms 22.3903 Ops/s 16.9055 Ops/s $\textbf{\color{#35bf28}+32.44\%}$
test_cql_speed[True-None] 16.4706ms 15.4057ms 64.9110 Ops/s 63.7826 Ops/s $\color{#35bf28}+1.77\%$
test_cql_speed[True-backward] 23.1751ms 22.2001ms 45.0448 Ops/s 44.7071 Ops/s $\color{#35bf28}+0.76\%$
test_cql_speed[reduce-overhead-None] 16.9366ms 15.5452ms 64.3285 Ops/s 63.6822 Ops/s $\color{#35bf28}+1.01\%$
test_cql_speed[reduce-overhead-backward] 23.2932ms 22.1174ms 45.2133 Ops/s 44.3887 Ops/s $\color{#35bf28}+1.86\%$
test_a2c_speed[False-None] 0.3353s 9.4392ms 105.9412 Ops/s 139.3649 Ops/s $\textbf{\color{#d91a1a}-23.98\%}$
test_a2c_speed[False-backward] 14.9027ms 14.1726ms 70.5588 Ops/s 71.2837 Ops/s $\color{#d91a1a}-1.02\%$
test_a2c_speed[True-None] 5.5693ms 3.3469ms 298.7809 Ops/s 297.3819 Ops/s $\color{#35bf28}+0.47\%$
test_a2c_speed[True-backward] 13.2574ms 10.3394ms 96.7175 Ops/s 102.8682 Ops/s $\textbf{\color{#d91a1a}-5.98\%}$
test_a2c_speed[reduce-overhead-None] 3.9417ms 3.3052ms 302.5546 Ops/s 300.3829 Ops/s $\color{#35bf28}+0.72\%$
test_a2c_speed[reduce-overhead-backward] 10.1781ms 9.6713ms 103.3987 Ops/s 101.8544 Ops/s $\color{#35bf28}+1.52\%$
test_ppo_speed[False-None] 8.8630ms 7.3618ms 135.8359 Ops/s 133.1701 Ops/s $\color{#35bf28}+2.00\%$
test_ppo_speed[False-backward] 15.4181ms 14.3408ms 69.7311 Ops/s 68.5147 Ops/s $\color{#35bf28}+1.78\%$
test_ppo_speed[True-None] 5.8241ms 3.7481ms 266.8035 Ops/s 267.6168 Ops/s $\color{#d91a1a}-0.30\%$
test_ppo_speed[True-backward] 10.0723ms 9.6006ms 104.1596 Ops/s 103.9701 Ops/s $\color{#35bf28}+0.18\%$
test_ppo_speed[reduce-overhead-None] 4.9092ms 3.7078ms 269.7039 Ops/s 267.5365 Ops/s $\color{#35bf28}+0.81\%$
test_ppo_speed[reduce-overhead-backward] 10.0766ms 9.6014ms 104.1510 Ops/s 104.4821 Ops/s $\color{#d91a1a}-0.32\%$
test_reinforce_speed[False-None] 7.1243ms 6.4510ms 155.0142 Ops/s 152.7655 Ops/s $\color{#35bf28}+1.47\%$
test_reinforce_speed[False-backward] 9.9587ms 9.6566ms 103.5563 Ops/s 96.6236 Ops/s $\textbf{\color{#35bf28}+7.18\%}$
test_reinforce_speed[True-None] 6.5861ms 2.6353ms 379.4573 Ops/s 374.9203 Ops/s $\color{#35bf28}+1.21\%$
test_reinforce_speed[True-backward] 8.8688ms 8.5075ms 117.5428 Ops/s 115.6152 Ops/s $\color{#35bf28}+1.67\%$
test_reinforce_speed[reduce-overhead-None] 3.0204ms 2.6269ms 380.6794 Ops/s 374.7553 Ops/s $\color{#35bf28}+1.58\%$
test_reinforce_speed[reduce-overhead-backward] 9.6278ms 8.5475ms 116.9937 Ops/s 116.0781 Ops/s $\color{#35bf28}+0.79\%$
test_iql_speed[False-None] 33.8543ms 31.8437ms 31.4034 Ops/s 30.5843 Ops/s $\color{#35bf28}+2.68\%$
test_iql_speed[False-backward] 46.4280ms 44.2871ms 22.5800 Ops/s 21.8847 Ops/s $\color{#35bf28}+3.18\%$
test_iql_speed[True-None] 13.8003ms 13.1577ms 76.0011 Ops/s 73.8660 Ops/s $\color{#35bf28}+2.89\%$
test_iql_speed[True-backward] 25.0048ms 23.9593ms 41.7375 Ops/s 40.8341 Ops/s $\color{#35bf28}+2.21\%$
test_iql_speed[reduce-overhead-None] 14.1753ms 13.2451ms 75.4998 Ops/s 72.8992 Ops/s $\color{#35bf28}+3.57\%$
test_iql_speed[reduce-overhead-backward] 25.0344ms 24.0049ms 41.6582 Ops/s 40.9699 Ops/s $\color{#35bf28}+1.68\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.8196ms 5.0647ms 197.4449 Ops/s 191.7174 Ops/s $\color{#35bf28}+2.99\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.1952ms 0.4761ms 2.1005 KOps/s 2.0820 KOps/s $\color{#35bf28}+0.89\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.9036ms 0.4528ms 2.2084 KOps/s 2.1998 KOps/s $\color{#35bf28}+0.39\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 8.5953ms 4.9874ms 200.5066 Ops/s 200.6614 Ops/s $\color{#d91a1a}-0.08\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.2916ms 0.4711ms 2.1228 KOps/s 2.1102 KOps/s $\color{#35bf28}+0.60\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7460ms 0.4481ms 2.2314 KOps/s 2.2191 KOps/s $\color{#35bf28}+0.55\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.9658ms 1.6037ms 623.5566 Ops/s 621.1822 Ops/s $\color{#35bf28}+0.38\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.1374ms 1.5126ms 661.1162 Ops/s 653.7634 Ops/s $\color{#35bf28}+1.12\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.3707ms 5.1189ms 195.3544 Ops/s 187.8006 Ops/s $\color{#35bf28}+4.02\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.3152ms 0.6056ms 1.6514 KOps/s 1.6233 KOps/s $\color{#35bf28}+1.73\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7953ms 0.5791ms 1.7270 KOps/s 1.7106 KOps/s $\color{#35bf28}+0.96\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.7271ms 5.0107ms 199.5743 Ops/s 194.7073 Ops/s $\color{#35bf28}+2.50\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.5414ms 0.4818ms 2.0756 KOps/s 2.0566 KOps/s $\color{#35bf28}+0.93\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6609ms 0.4524ms 2.2106 KOps/s 2.1869 KOps/s $\color{#35bf28}+1.08\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.2141ms 4.8897ms 204.5132 Ops/s 195.6714 Ops/s $\color{#35bf28}+4.52\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9996ms 0.4744ms 2.1079 KOps/s 2.1277 KOps/s $\color{#d91a1a}-0.93\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6082ms 0.4490ms 2.2271 KOps/s 2.1882 KOps/s $\color{#35bf28}+1.78\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.6124ms 5.1889ms 192.7204 Ops/s 189.8942 Ops/s $\color{#35bf28}+1.49\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.3851s 1.1133ms 898.1939 Ops/s 1.6336 KOps/s $\textbf{\color{#d91a1a}-45.02\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8011ms 0.5844ms 1.7112 KOps/s 1.6923 KOps/s $\color{#35bf28}+1.11\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.2443ms 4.1328ms 241.9695 Ops/s 234.1564 Ops/s $\color{#35bf28}+3.34\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 17.3715ms 12.7886ms 78.1946 Ops/s 76.5969 Ops/s $\color{#35bf28}+2.09\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 4.4328ms 1.3567ms 737.0786 Ops/s 761.5595 Ops/s $\color{#d91a1a}-3.21\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.3460s 10.9660ms 91.1914 Ops/s 242.3679 Ops/s $\textbf{\color{#d91a1a}-62.37\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 17.5121ms 12.9766ms 77.0618 Ops/s 77.6405 Ops/s $\color{#d91a1a}-0.75\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.9938ms 1.2804ms 781.0169 Ops/s 745.1827 Ops/s $\color{#35bf28}+4.81\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 6.0207ms 4.2635ms 234.5517 Ops/s 238.8473 Ops/s $\color{#d91a1a}-1.80\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.6965ms 12.8859ms 77.6044 Ops/s 27.4153 Ops/s $\textbf{\color{#35bf28}+183.07\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.0843ms 1.4322ms 698.2100 Ops/s 683.5981 Ops/s $\color{#35bf28}+2.14\%$

@vmoens
Update
8820706 
[ghstack-poisoned]
@vmoens vmoens merged commit 8820706 into gh/vmoens/21/base Sep 17, 2024
12 of 29 checks passed
@vmoens vmoens deleted the gh/vmoens/21/head branch September 17, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot