Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change variable to parameter #190

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

baijumeswani
Copy link
Collaborator

Artifact uploading was failing. With this change, the package upload should succeed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 5, 2024
Copy link
Contributor

@YUNQIUGUO YUNQIUGUO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks the fix! Will update when torch-ort release pipeline pass following up this fix.

@YUNQIUGUO
Copy link
Contributor

pytorch_ort_stable pipeline now passes. will go ahead and merge this pr. thanks!

@YUNQIUGUO YUNQIUGUO merged commit dd598eb into main Feb 5, 2024
3 checks passed
YUNQIUGUO added a commit that referenced this pull request Feb 5, 2024
…rtifact

Cherry-pick "Change variable to parameter(#190)"
@baijumeswani baijumeswani deleted the baijumeswani/variable-to-parameter branch February 6, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants