Add --op-collection option #2503
Open
+47
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FindHao
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
FindHao
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
FindHao
commented
Oct 10, 2024
| @@ -40,8 +59,16 @@ def _list_opbench_paths() -> List[str]: | |||
| return opbench | |||
|
|
|||
|
|
|||
| def list_operators() -> List[str]: | |||
| def list_operators(op_collection: OP_COLLECTION = OP_COLLECTION.DEFAULT) -> List[str]: | |||
There was a problem hiding this comment.
@xuzhao9 maybe we should use List(str) as the argument?
FindHao
commented
Oct 10, 2024
FindHao
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
I am thinking we should have a clearer place to manage operator collection. Can we create a new directory |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add
--op-collectionto tritonbench. It can run multiple ops in defined operator collections. The default collection includes all ops not included in other collections.Operator collections are defined in
torchbenchmark/operators/__init__.py