Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timm_efficientdet: benchmark coverage for custom devices #2374

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

weishi-deng
Copy link
Contributor

Works for Roadmap #1293 to increase benchmark coverage.
This model implementation is hard-code with CUDA due to the 3rd-party repo dependency which makes that running on the custom devices except for CUDA(e.g. XPU) will raise the runtime error.
In this PR, we accept the device arg as a parameter within the training and inference processes, which will cover the model initializing and data transposition for these custom devices.

@weishi-deng weishi-deng marked this pull request as draft July 12, 2024 09:50
@weishi-deng
Copy link
Contributor Author

Pls hold until the custom devices support for https://github.com/rwightman/efficientdet-pytorch is merged.

Copy link

@EikanWang EikanWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weishi-deng
Copy link
Contributor Author

The PR for third-party dependency rwightman/efficientdet-pytorch#299 is merged. @EikanWang pls help review again and I will mark this PR as "ready for review" if no change.

@EikanWang
Copy link

@weishi-deng , Perfect! This PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants