-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch from fx.symbolic_trace to dynamo_trace for converter test part-1 #3261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable converter dynamic shape tests to use dynamoc tracer batch by batch current batch: test_a*.py
lanluo-nvidia
added
the
WIP
Work is in progress, pull request should not be merged yet
label
Oct 23, 2024
github-actions
bot
added
component: api [Python]
Issues re: Python API
component: dynamo
Issues relating to the `torch.compile` or `torch._dynamo.export` paths
labels
Oct 27, 2024
lanluo-nvidia
changed the title
switch from fx.symbolic_trace to dynamo_trace for converter test part-1 (Still WIP)
switch from fx.symbolic_trace to dynamo_trace for converter test part-1
Oct 27, 2024
lanluo-nvidia
removed
the
WIP
Work is in progress, pull request should not be merged yet
label
Oct 27, 2024
narendasan
reviewed
Oct 28, 2024
narendasan
reviewed
Oct 28, 2024
narendasan
reviewed
Oct 28, 2024
github-actions
bot
added
documentation
Improvements or additions to documentation
and removed
component: api [Python]
Issues re: Python API
component: dynamo
Issues relating to the `torch.compile` or `torch._dynamo.export` paths
labels
Oct 29, 2024
github-actions
bot
removed
the
documentation
Improvements or additions to documentation
label
Oct 30, 2024
peri044
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor question. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch from fx.symbolic_trace to dynamo trace for converter test part-1
Since we ~2000 test cases I splited into batches to migrate them off fx.symbolic_trace
current batch: tests/py/dynamo/conversion/test_a*.py
There mainly two types of testcases require change:
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: