Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from fx.symbolic_trace to dynamo_trace for converter test part-1 #3261

Merged
merged 43 commits into from
Nov 5, 2024

Conversation

lanluo-nvidia
Copy link
Collaborator

@lanluo-nvidia lanluo-nvidia commented Oct 23, 2024

Description

Switch from fx.symbolic_trace to dynamo trace for converter test part-1

Since we ~2000 test cases I splited into batches to migrate them off fx.symbolic_trace

current batch: tests/py/dynamo/conversion/test_a*.py

There mainly two types of testcases require change:

  1. for ops require custom dynamic shape support, will be changed to use dynamic_shapes instead of Input
  2. for ops will be decomposed into multiple ops, these op test will be added in the test_composite_aten_op.py

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia added the WIP Work is in progress, pull request should not be merged yet label Oct 23, 2024
@lanluo-nvidia lanluo-nvidia self-assigned this Oct 23, 2024
@github-actions github-actions bot added the component: tests Issues re: Tests label Oct 23, 2024
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Oct 27, 2024
@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review October 27, 2024 22:15
@lanluo-nvidia lanluo-nvidia changed the title switch from fx.symbolic_trace to dynamo_trace for converter test part-1 (Still WIP) switch from fx.symbolic_trace to dynamo_trace for converter test part-1 Oct 27, 2024
@lanluo-nvidia lanluo-nvidia removed the WIP Work is in progress, pull request should not be merged yet label Oct 27, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Oct 29, 2024
@lanluo-nvidia lanluo-nvidia changed the base branch from lluo/save_remove_inputs to main October 30, 2024 16:06
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Oct 30, 2024
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor question. LGTM

tests/py/dynamo/conversion/test_attention.py Outdated Show resolved Hide resolved
@lanluo-nvidia lanluo-nvidia merged commit e43833d into main Nov 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants