Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove python 2 unicode compatible #667

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove python 2 unicode compatible #667

wants to merge 2 commits into from

Conversation

sks444
Copy link
Contributor

@sks444 sks444 commented Apr 10, 2020 •
edited
Loading

Closes #666

@coveralls
Copy link

coveralls commented Apr 10, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 66.917% when pulling 2926b01 on sks444:remove-python_2_unicode_compatible into 49af450 on pythonindia:master.

pradyunsg
pradyunsg approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very reasonable!

@pradyunsg pradyunsg closed this Apr 15, 2020
@pradyunsg pradyunsg reopened this Apr 15, 2020
@pradyunsg
Copy link
Contributor

Do your thing Travis CI.

@ananyo2012 ananyo2012 mentioned this pull request May 2, 2020
Closed
@sks444 sks444 force-pushed the remove-python_2_unicode_compatible branch from 2926b01 to 35bb9e9 Compare May 6, 2020 07:16
@pradyunsg
Copy link
Contributor

Does anyone have concerns with this?

@palnabarun palnabarun closed this May 7, 2020
@palnabarun palnabarun reopened this May 7, 2020
@palnabarun
Copy link
Member

Note: Putting a hold on the merge until the upgrade compatibility is tested

@palnabarun
Copy link
Member

@sks444 This is a good to go change for Python 3. Thank you! 🙂

@ananyo2012
Copy link
Contributor

@sks444 Can you rebase the changes ?

@sks444 sks444 force-pushed the remove-python_2_unicode_compatible branch from 6854c9e to 57d50e4 Compare June 7, 2020 16:09
@palnabarun
Copy link
Member

@sks444 -- can you please rebase the changes against master?

@sks444 sks444 force-pushed the remove-python_2_unicode_compatible branch from 57d50e4 to 88ad96e Compare June 7, 2020 18:48
@pradyunsg pradyunsg mentioned this pull request Dec 12, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananyo2012 ananyo2012 ananyo2012 approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove use of python_2_unicode_compatible from Django models
5 participants
@sks444 @coveralls @pradyunsg @palnabarun @ananyo2012