fixing minor bugs in theme component & a previous blog #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shashank Kumar <[email protected]>
|
About the slug you changed, this would change the permalink of that blog. We shouldn't do that. The slugs may not be unique as the permalink is /{category}/{slug}.html. |
|
@palnabarun have reverted changes made on slug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shashank Kumar [email protected]
Minor bugs have been fixed in theme components and a 2020 blog slug.
What is the current behavior? (You can also link to an open issue here)
This might be causing theme issue in prod but I'm not sure since I cannot reproduce that bug.
What is the new behavior (if this is a feature change)?
This will fix import issue for fontawesome css file and slug issue of a 2020 blog.