Bug Fix: terminate when error is encountered #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhellmann
reviewed
Nov 7, 2024
src/fromager/__main__.py
Outdated
| @@ -249,7 +250,7 @@ def invoke_main() -> None: | |||
| ) # log the full traceback details to the debug log file, if any | |||
| logger.error(f"ERROR: {err}") | |||
| if _DEBUG: | |||
| raise | |||
| sys.exit(1) | |||
There was a problem hiding this comment.
This isn't quite what we want.
We always want the exit with an error if there's an exception. When _DEBUG is set, then we want to raise the exception again to get the traceback. So, I think we want something like this
Suggested change
| sys.exit(1) | |
| raise | |
| sys.exit(1) |
There was a problem hiding this comment.
Ah okay. Pushed changes again
rd4398
force-pushed
the
fix-error-msg-bug
branch
from
6e7777f
to
f2660fc
Compare
dhellmann
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug related to error message handling. The
mainwill now exit usingsys.exit(1)when there is an error