Don't write to Fromager's virtual env #437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
force-pushed
the
isolate_build_env
branch
2 times, most recently
from
5d6ed1b
to
b9e98be
Compare
Until now, Fromager was installing build dependencies into its virtual environment. The build dependencies were necessary to run `pyproject_hooks`. Some hooks expect build dependencies and build system providers to be installed. Fromager now uses a new virtualenv that is bound to the `WorkContext`. The build dependencies are installed into the work environment. The hook caller uses the interpreter from the work env instead of Fromager's interpreter. The context environment will eventually go away after we have refactored the code to use the package's build env. Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
isolate_build_env
branch
from
b9e98be
to
06560d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, Fromager was installing build dependencies into its virtual
environment. The build dependencies were necessary to run
pyproject_hooks. Some hooks expect build dependencies and build systemproviders to be installed.
Fromager now uses a new virtualenv that is bound to the
WorkContext.The build dependencies are installed into the work environment. The hook
caller uses the interpreter from the work env instead of Fromager's
interpreter.
The context environment will eventually go away after we have refactored
the code to use the package's build env.