Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix tests #14

wants to merge 2 commits into from

Conversation

j-maas
Copy link
Contributor

@j-maas j-maas commented Oct 3, 2017

Just some quick and naive fixes to make the tests pass.

@codecov
Copy link

codecov bot commented Oct 3, 2017

Codecov Report

Merging #14 into master will decrease coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   99.68%   99.46%   -0.22%     
==========================================
  Files          11       11              
  Lines         939      941       +2     
==========================================
  Hits          936      936              
- Misses          3        5       +2
Impacted Files Coverage Δ
ptbtest/usergenerator.py 100% <ø> (ø) ⬆️
ptbtest/mockbot.py 99.48% <100%> (ø) ⬆️
ptbtest/messagegenerator.py 99.28% <0%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d931aa...7156b5d. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 3, 2017

Codecov Report

Merging #14 into master will decrease coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   99.68%   99.46%   -0.22%     
==========================================
  Files          11       11              
  Lines         939      941       +2     
==========================================
  Hits          936      936              
- Misses          3        5       +2
Impacted Files Coverage Δ
ptbtest/usergenerator.py 100% <ø> (ø) ⬆️
ptbtest/mockbot.py 99.48% <100%> (ø) ⬆️
ptbtest/messagegenerator.py 99.28% <0%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d931aa...bca2e2b. Read the comment docs.

@j-maas
Copy link
Contributor Author

j-maas commented Oct 3, 2017

The build only fails on Python 2.7 and PyPI. I have added an __init__.py to PtbMock which I hope solves the issue, but of course this doesn't trigger a rebuild here. @Eldinnie, could you prompt Travis to rebuild, please?

@Bibo-Joshi
Copy link
Member

Hi. I'm notifying everyone who PRed to this repo about #21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants