Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new backend for LinkedIn OpenID Connect #833

Merged
merged 9 commits into from
Oct 31, 2023

Conversation

noxan
Copy link
Contributor

@noxan noxan commented Sep 23, 2023

Proposed changes

LinkedIn OAuth2 has been deprecated as of August 2023 and been replace with OpenID connect.
This pull request adds LinkedIn OpenID Connect. It has a few specific adjustments as LinkedIn does not send any "nonce" and therefore does not work with the regular OpenID Connect implementation.

Thanks to #829 for the idea and the hint on the OpenID Connect auth base class.

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@noxan noxan requested a review from nijel October 5, 2023 17:38
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ca841a0) 77.11% compared to head (e89c1f3) 77.09%.
Report is 7 commits behind head on master.

❗ Current head e89c1f3 differs from pull request most recent head e5b7568. Consider uploading reports for the commit e5b7568 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #833      +/-   ##
==========================================
- Coverage   77.11%   77.09%   -0.03%     
==========================================
  Files         337      337              
  Lines       10262    10276      +14     
  Branches      690      692       +2     
==========================================
+ Hits         7914     7922       +8     
- Misses       2192     2198       +6     
  Partials      156      156              
Flag Coverage Δ
unittests 77.09% <60.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
social_core/backends/linkedin.py 71.62% <60.00%> (-3.38%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noxan
Copy link
Contributor Author

noxan commented Oct 11, 2023

@nijel sorry I missed your initial comment, resolved your feedback. anything else keeping us from adding this pull request?

@nijel
Copy link
Member

nijel commented Oct 17, 2023

Can you please also add tests for this?

@nijel
Copy link
Member

nijel commented Oct 17, 2023

...and documentation to https://github.com/python-social-auth/social-docs

@noxan
Copy link
Contributor Author

noxan commented Oct 20, 2023

haha, sure. i'll look into it :)

@noxan
Copy link
Contributor Author

noxan commented Oct 20, 2023

tests should be ready, i'm preparing the docs as another pull request and will link it here, once i'm ready.

@nijel nijel merged commit e0cb888 into python-social-auth:master Oct 31, 2023
7 checks passed
@nijel
Copy link
Member

nijel commented Oct 31, 2023

Merged, thanks for your contribution! Please followup with the documentation PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants