Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit build-system to current major version of poetry-core by default #9812

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Oct 30, 2024

Pull Request Check List

Until now when generating a new pyproject.toml there is no version range given for poetry-core in the [build-system] section.

Most people stick to the default. This become a problem as soon as poetry-core introduces a breaking change. While users have control over runtime dependencies in case of any incompatibility, it is not possible to tell which version of the build-system requirements should be used.

This is why we should limit the poetry-core version in the [build-system] section to the current major version of poetry-core by default when generating a new `pyproject.toml.

  • Added tests for changed code.
  • Updated documentation for changed code.

@finswimmer finswimmer marked this pull request as ready for review October 30, 2024 07:08
@finswimmer finswimmer requested a review from a team October 30, 2024 07:08
@Secrus Secrus merged commit 2b72872 into python-poetry:main Oct 30, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants