feat(config)!: rename experimental.system-git-client to system-git-client #9787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finswimmer
force-pushed
the
git-system-client
branch
from
d0df007
to
2917d4c
Compare
Secrus
reviewed
Oct 21, 2024
There was a problem hiding this comment.
I wonder if we could add some feature to config to make the transition easier for users. Right now, if someone has the "old" version of the option, they would have to manually set the new option too. Any ideas?
There was a problem hiding this comment.
I thought about it as well. Because I couldn't come up immediately with a solution, I decided to say: It's a major version bump with breaking changes and users have to check there config for necessary changes.
If we have strong feelings about the user experience here, I have to think about it more deeply.
Secrus
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experimental.system-git-clientwas introduced in 1.2.0. Let's stop calling it "experimental".