Remove redundant Executor.submit() call #9677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the ThreadPoolExecutor is idle, this code: ```python from concurrent.futures import wait, ThreadpoolExecutor executor: ThreadpoolExecutor wait([executor.submit(fn, arg)]) ``` is equivalent to ```python fn(arg) ``` Remove one such redundant call in installation/executor.py
TheSven73
force-pushed
the
mr-submit-fix
branch
from
35b35d0
to
5247e35
Compare
Secrus
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ThreadPoolExecutor is idle, this code:
is equivalent to
Remove one such redundant call in installation/executor.py