Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for the "deprecated" keyword #1171

Conversation

edgarrmondragon
Copy link

@edgarrmondragon edgarrmondragon commented Sep 28, 2023

@edgarrmondragon edgarrmondragon temporarily deployed to PyPI September 28, 2023 01:45 — with GitHub Actions Inactive
@Julian
Copy link
Member

Julian commented Sep 28, 2023

Let's discuss this on #1170, which I may not have time to write a longer response on now but will try to tomorrow. Broadly though, I wouldn't merge this PR for a few reasons (likely additional to what I'll write there)

  • the Validator protocol is for general non-dialect-specific behavior. Meaning things that go there should apply to any conceivable JSON Schema dialect -- including ones that have no deprecated keyword whatsoever.
  • I won't add boolean flags to any API
  • There's an existing extend API for adding behavior to a dialect (which could be used to control whether any behavior is assigned to the keyword or not) without needing to add something specifically new

I'll put some additional thoughts on the issue.

And regardless, thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support encountering of a "deprecated": true keyword by propagating a deprecation warning
2 participants