Update __init__.py #149
Closed
Update __init__.py #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On non-Windows systems: things stay as they are On windows system: it would pass the path to the thrift file with "file://" scheme. If ThriftPY is fixed to handle the 'file' scheme - things would work on windows. Until then, things will stay broken, as they are now. This is further discussed here: python-happybase#148 and here: Thriftpy/thriftpy#269 NOTE: I created a corresponding fork and pull request on thrifypy as well: Thriftpy/thriftpy#270
|
thanks, but i'd rather see this fixed in thriftpy. also, this pr adds code duplication. |
|
is this still relevant? as i said, this seems a i will close this pr now, but feel free to open additional issues in case there is anything here that happybase itself should take care of. thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On non-Windows systems: things stay as they are
On windows system: it would pass the path to the thrift file with "file://" scheme.
If ThriftPY is fixed to handle the 'file' scheme - things would work on windows.
Until then, things will stay broken, as they are now.
This is further discussed here: #148
and here: Thriftpy/thriftpy#269
NOTE: I created a corresponding fork and pull request on thrifypy as well:
Thriftpy/thriftpy#270