Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "christmasify" avatar effect command. #1466

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SockYeh
Copy link
Contributor

@SockYeh SockYeh commented Feb 21, 2024

Relevant Issues

Closes #937

Description

  • Added "christmasify" command to add a Christmas touch to user's avatar.
  • Currently has 2 effects - Room for future additions
    • Make avatar chilly
    • Add ornaments

Did you:

Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great :)

Where did you get ice_frame.png and ornaments_frame.png from? We need to make sure they're licensed appropriately so we can use them here. I also wonder if there's a higher quality version of ice_frame.png, currently it looks quite blurry.

bot/exts/avatar_modification/_effects.py Show resolved Hide resolved
@SockYeh
Copy link
Contributor Author

SockYeh commented Feb 23, 2024

This looks great :)

Where did you get ice_frame.png and ornaments_frame.png from? We need to make sure they're licensed appropriately so we can use them here. I also wonder if there's a higher quality version of ice_frame.png, currently it looks quite blurry.

It was just downloaded from google so i have no clue where the source actually is 😅

@vivekashok1221
Copy link
Member

This looks great :)
Where did you get ice_frame.png and ornaments_frame.png from? We need to make sure they're licensed appropriately so we can use them here. I also wonder if there's a higher quality version of ice_frame.png, currently it looks quite blurry.

It was just downloaded from google so i have no clue where the source actually is 😅

Reverse image search for ornaments_frame.png led me to this (among other similar looking websites). They've mentioned that they do not require attribution for non-commercial uses.

ice_frame.png can be found on freepik.com here and they've stated that they require attribution. (Also I do not see a .png download option but they do have .svg). It seems that the same author has also uploaded the image to shutterstock.

@SockYeh
Copy link
Contributor Author

SockYeh commented Feb 23, 2024

This looks great :)
Where did you get ice_frame.png and ornaments_frame.png from? We need to make sure they're licensed appropriately so we can use them here. I also wonder if there's a higher quality version of ice_frame.png, currently it looks quite blurry.

It was just downloaded from google so i have no clue where the source actually is 😅

Reverse image search for ornaments_frame.png led me to this (among other similar looking websites). They've mentioned that they do not require attribution for non-commercial uses.

ice_frame.png can be found on freepik.com here and they've stated that they require attribution. (Also I do not see a .png download option but they do have .svg). It seems that the same author has also uploaded the image to shutterstock.

that's great! What is the next step?

@wookie184
Copy link
Contributor

Ideally we'd use assets that don't require attribution, since that's the easiest option where possible.

For ones that do require attribution, I think it's OK to put it in the command's help text.

@SockYeh
Copy link
Contributor Author

SockYeh commented Apr 25, 2024

I am unable to find images so would be grateful if someone could find one to add to the bot. Thanks.

@Xithrius Xithrius added type: feature Relating to the functionality of the application. area: backend Related to internal functionality and utilities status: needs review Author is waiting for someone to review and approve category: holidays Related to holidays (Christmas, Halloween, Valentine's) labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to internal functionality and utilities category: holidays Related to holidays (Christmas, Halloween, Valentine's) status: needs review Author is waiting for someone to review and approve type: feature Relating to the functionality of the application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New ".christmasify" command
4 participants