Use LDAP uid in reset message instead of discord username #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb3
requested changes
Jul 30, 2024
vivekashok1221
force-pushed
the
vivek/uid-reset-msg
branch
from
3944309
to
a8502df
Compare
jchristgit
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we display the user's discord username rather than the LDAP uid in the password reset instructions, when it is the LDAP uid that is used for login. This PR changes the interaction message to include the LDAP uid instead of the discord username.
Note: I haven't tested the changes locally since I don't have LDAP set up locally.