Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDAP Bootstrapping #247

Merged
merged 17 commits into from
Jul 26, 2024
Merged

LDAP Bootstrapping #247

merged 17 commits into from
Jul 26, 2024

Conversation

jb3
Copy link
Member

@jb3 jb3 commented Jul 26, 2024

  • Add new dependencies for LDAP, FreeIPA and Keycloak interaction
  • Add new configuration options for talking to Keycloak, FreeIPA and LDAP
  • Add new constants to define enrollment parameters and requirements
  • Add new directory APIs for working with FreeIPA, Keycloak and LDAP
  • Add a cog for managing the syncronisation of enrolled users to LDAP
  • Update the Grafana team syncer to sync both LDAP and GitHub users

decorator-factory
decorator-factory reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@decorator-factory decorator-factory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nitpicks

arthur/apis/directory/ldap.py Outdated Show resolved Hide resolved
arthur/apis/directory/ldap.py Outdated Show resolved Hide resolved
arthur/exts/directory/ldap.py Outdated Show resolved Hide resolved
arthur/exts/directory/ldap.py Outdated Show resolved Hide resolved
arthur/exts/directory/ldap.py Outdated Show resolved Hide resolved
arthur/exts/directory/ldap.py Outdated Show resolved Hide resolved
@jb3 jb3 force-pushed the jb3/features/ldap-bootstrapping branch from 26d151d to 1d1ddd2 Compare July 26, 2024 17:08
jb3
jb3 commented Jul 26, 2024
View reviewed changes
Copy link
Member Author

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All review comments addressed in force push

arthur/apis/directory/ldap.py Outdated Show resolved Hide resolved
arthur/apis/directory/ldap.py Outdated Show resolved Hide resolved
arthur/exts/directory/ldap.py Outdated Show resolved Hide resolved
decorator-factory
decorator-factory approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@decorator-factory decorator-factory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it's probably better if someone who's seen the codebase approves as well

@jb3 jb3 force-pushed the jb3/features/ldap-bootstrapping branch 2 times, most recently from 8d2c3d5 to 3b975ff Compare July 26, 2024 19:12
@jb3 jb3 force-pushed the jb3/features/ldap-bootstrapping branch from 3b975ff to 0bb3c88 Compare July 26, 2024 19:27
ChrisLovering
ChrisLovering approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@ChrisLovering ChrisLovering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 :shipit:

@jb3 jb3 merged commit 0bb3c88 into main Jul 26, 2024
6 checks passed
@jb3 jb3 deleted the jb3/features/ldap-bootstrapping branch July 26, 2024 19:37
@sentry-io Sentry.io
Copy link

sentry-io bot commented Jul 30, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Unauthorized: Unauthorized: bad credentials. arthur.apis.directory.freeipa in create_user View Issue
  • ‼️ ConnectionError: Server Down. (0x0051 [81]) arthur.apis.directory.ldap in find_users View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLovering ChrisLovering ChrisLovering approved these changes

@decorator-factory decorator-factory decorator-factory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Infrastructure
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jb3 @ChrisLovering @decorator-factory