Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.11 to 3.12 #250

Closed
wants to merge 1 commit into from
Closed

Python 3.11 to 3.12 #250

wants to merge 1 commit into from

Conversation

Xithrius
Copy link
Member

@Xithrius Xithrius commented Jul 4, 2024

Closes #201

@netlify Netlify
Copy link

netlify bot commented Jul 4, 2024 •
edited
Loading

✅ Deploy Preview for bot-core ready!

Name Link
🔨 Latest commit f16d377
🔍 Latest deploy log https://app.netlify.com/sites/bot-core/deploys/668734ba39756f0008aa8087
😎 Deploy Preview https://deploy-preview-250--bot-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Xithrius
Python 3.11 to 3.12
f16d377 
Upgraded docs to 3.12

Removed 3.11 from lint-test CI matrix
@Xithrius Xithrius added a: dependencies Pull requests which update a dependency file t: enhancement labels Jul 4, 2024
ChrisLovering
ChrisLovering requested changes Jul 5, 2024
View reviewed changes
Copy link
Member

@ChrisLovering ChrisLovering left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already support Python 3.12, hence the ^3.11 version specifier, and why run the tests under both 3.11 and 3.12.

This PR is just dropping support for 3.11, which I don't think we should do yet.

@Xithrius
Copy link
Member Author

Xithrius commented Jul 5, 2024

I simply am unable to read, misread the ^3.11 lol

@Xithrius Xithrius closed this Jul 5, 2024
@Xithrius Xithrius deleted the py312 branch July 5, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLovering ChrisLovering ChrisLovering requested changes

@wookie184 wookie184 Awaiting requested review from wookie184

Assignees
No one assigned
Labels
a: dependencies Pull requests which update a dependency file t: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Python 3.12
2 participants
@Xithrius @ChrisLovering