fix undefined var 'user' #654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a user, group is defined in diamond.conf, we end up with the below error, ERROR: Failed to set UID/GID. global name 'user' is not defined
|
this can also be used as an alternative |
|
Can you rebase on master? As a side note, the alternative mentioned above won't work since user has two config sources, not one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a user, group is defined in diamond.conf, we end up with the below error,
ERROR: Failed to set UID/GID. global name 'user' is not defined
Seems to be introduced in ad3862d76c,
This fixes it on nix based OS's, it needs testing on 'nt' based systems since 'pwd' might not be available on those