Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PostgreSQL handler #635

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cgalisteo
Copy link

Adding a PostgreSQL handler based on the already available MySQL one.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 24.256% when pulling cabd335 on cgalisteo:postgresql-handler into cd27182 on python-diamond:master.

# coding=utf-8

"""
Insert the collected values into a table
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace double space near end with postgreSQL


class PostgreSQLHandler(Handler):
"""
Implements the abstract Handler class, sending data to a mysql table
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mysql should be postgresql

config = super(PostgreSQLHandler, self).get_default_config_help()

config.update({
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add descriptions for all the config options?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants