Fix infinite redirect loop with httpd collector, support HTTPS #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 21, 2016 13:48
Without an upper bound on the number of redirects, redirects loops (caused either by client- or server-side bugs) will lead to infinite loops in the collector, potentially preventing any statistics from being reported at all. Set a default of 5 redirects, maximum, with a configurable setting to adjust this.
Previously, HttpdCollector assumed all URLs on their default ports were requests to port 80. In the case of a `http://localhost/` -> `https://localhost/` redirect, the latter URL is parsed by `urlparse` as "Host localhost on the default port" (`parts.netloc` aka `parts[1]` did not contain a `:`), and a request is made to `http://localhost/`, which promptly re-redirects to HTTPS again. Transition to using the attribute names of `urlparse` for readability, and support both HTTP and HTTPS URLs, by examining the scheme and constructing the correct httplib class accordingly.
shortdudey123
requested changes
Feb 16, 2017
|
Will do! |
|
Will merge once previous comment is handled and merge conflicts are fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these, a status page which redirects HTTP to HTTPS causes an infinite loop and wedges the local collector.