Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying an explicit format in parse_date/parse_time #1131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Sep 22, 2024

Closes #1090

This uses parse_pattern internally when a custom format is used.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (f91754b) to head (e01ec55).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
+ Coverage   91.26%   91.27%   +0.01%     
==========================================
  Files          27       27              
  Lines        4602     4609       +7     
==========================================
+ Hits         4200     4207       +7     
  Misses        402      402              
Flag Coverage Δ
macos-12-3.10 90.08% <100.00%> (+0.01%) ⬆️
macos-12-3.11 90.01% <100.00%> (+0.01%) ⬆️
macos-12-3.12 90.19% <100.00%> (+0.01%) ⬆️
macos-12-3.13-dev 89.71% <100.00%> (+0.01%) ⬆️
macos-12-3.8 90.01% <100.00%> (+0.01%) ⬆️
macos-12-3.9 90.01% <100.00%> (+0.01%) ⬆️
macos-12-pypy3.10 90.08% <100.00%> (+0.01%) ⬆️
ubuntu-22.04-3.10 90.10% <100.00%> (+0.01%) ⬆️
ubuntu-22.04-3.11 90.04% <100.00%> (+0.01%) ⬆️
ubuntu-22.04-3.12 90.21% <100.00%> (+0.01%) ⬆️
ubuntu-22.04-3.13-dev 89.73% <100.00%> (+0.01%) ⬆️
ubuntu-22.04-3.8 90.03% <100.00%> (+0.01%) ⬆️
ubuntu-22.04-3.9 90.03% <100.00%> (+0.01%) ⬆️
ubuntu-22.04-pypy3.10 90.10% <100.00%> (+0.01%) ⬆️
windows-2022-3.10 90.22% <100.00%> (+0.01%) ⬆️
windows-2022-3.11 90.16% <100.00%> (+0.01%) ⬆️
windows-2022-3.12 90.33% <100.00%> (+0.01%) ⬆️
windows-2022-3.13-dev 89.85% <100.00%> (+0.01%) ⬆️
windows-2022-3.8 90.15% <100.00%> (+0.01%) ⬆️
windows-2022-3.9 90.15% <100.00%> (+0.01%) ⬆️
windows-2022-pypy3.10 90.22% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse functions should support a custom format
1 participant