Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extracting (deeply) nested calls in Python and Javascript #1127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Oct 10, 2024

  1. Allow extracting deeply nested calls in Python

    Currently the Python extractor does not support deeply nested gettext
    calls (deeper than as a direct argument to the top-level gettext call).
    
    e.g.
    ```py
    _("Hello %s", _("Person"))
    _("Hello %s",
      random_function(", ".join([_("Person 1"), _("Person 2")])))
    ```
    
    The extraction code was refactored quite a bit to simplify the flow and
    support this use-case.
    
    Fixes python-babel#1125
    (meanwhile also fixes python-babel#1123)
    dylankiss committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4eea9dd View commit details
    Browse the repository at this point in the history
  2. Allow extracting nested calls in Javascript

    Currently the Javascript extractor does not support nested gettext calls
    at all.
    
    The extraction code was refactored a bit to resemble the Python code
    as much as possible and support this use-case.
    dylankiss committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9131a83 View commit details
    Browse the repository at this point in the history