-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failures on babel version 2.14.0 #1059
Comments
I noticed some similar issues with ssf: snoopyjc/ssf#17 stemming from: https://github.com/python-babel/babel/releases/tag/v2.14.0
|
@nileshpatra Considering all of our tests are green on @Alex-ley-scrub That's unrelated – but as mentioned in the changelog, the format of |
Hi @akx
I suspect this has got something to do with tzdata version and the changes thereof. Is is possible to know what version of tzdata the CI pulls in?
Will |
As far as I can see, none of the errors above should be related to |
I think so - we are using babel's tarball directly off github releases which has .dat files processed already. We don't have to pull and convert at our end - do we? |
@nileshpatra Um... what tarball is that? The GitHub release for 2.14.0 has no sdist TAR. |
@akx oops, seems like I gave an incorrect response w/o properly checking - sorry for that! You're right indeed, there's no sdist. In debian, we generate .dat files via: https://github.com/python-babel/babel/blob/master/scripts/download_import_cldr.py#L12 I suppose this is the difference -- do you think babel can be adapted to latest CLDR data? |
@nileshpatra Sure, the work can be done to have Babel use CLDR 44, but that would be for Babel 2.15. Babel 2.14 uses CLDR 43 (#1043). |
Ack, I will wait for a new release then |
The freshly released Babel 2.15.0 uses CLDR 44. 🎉 The next version will use CLDR 45 when #1077 gets merged. |
Overview Description
While upgrading the Debian package to latest version I am observing a bunch of test failures on some locales due to minor changes. I'm not sure if the expected output should be changed for these assertions.
Steps to Reproducewhere I have no idea
if it makes sense to simply skip/patch.
Run the test suite with:
LC_ALL=C py.test-3
Actual Results
Expected Results
All tests should pass
Additional Information
Version info:
python3: 3.12.1
pytest: 7.4.4
tz: 2023.3.post1-2
freezegun: 1.2.1
unicode-cldr-core: 44-0.1
tzdata: 2023d-1
The text was updated successfully, but these errors were encountered: