Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use ordered publisher list #402

Merged
merged 3 commits into from
May 13, 2024
Merged

refactor: use ordered publisher list #402

merged 3 commits into from
May 13, 2024

Commits on May 13, 2024

  1. refactor: use ordered publisher list 

    This change brings down the average cost of a price update without
aggregation from 5k to 2k because binary search requires much less
lookups. There are mechanims implemented in the code to make sure
that upon the upgrade we sort the array without adding overhead to
the happy path (working binary search). Also add_publisher now does
an insertion sort to keep the list sorted and del_publisher won't
change the order of the list.
    @ali-bahjati
    ali-bahjati committed May 13, 2024
    Configuration menu
    Copy the full SHA
    c27465d View commit details
    Browse the repository at this point in the history

  2. refactor: use heapsort for each publisher addition too

    @ali-bahjati
    ali-bahjati committed May 13, 2024
    Configuration menu
    Copy the full SHA
    37e99b8 View commit details
    Browse the repository at this point in the history

  3. fix: address comments

    @ali-bahjati
    ali-bahjati committed May 13, 2024
    Configuration menu
    Copy the full SHA
    b991cba View commit details
    Browse the repository at this point in the history